Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mobile issue for babynama #2364

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Fixed mobile issue for babynama #2364

merged 2 commits into from
Mar 23, 2023

Conversation

mdshamoon
Copy link
Member

Summary

Fixed mobile issue for babynama

@mdshamoon mdshamoon self-assigned this Mar 20, 2023
@mdshamoon mdshamoon linked an issue Mar 20, 2023 that may be closed by this pull request
10 tasks
@github-actions
Copy link

github-actions bot commented Mar 20, 2023

@github-actions github-actions bot temporarily deployed to pull request March 20, 2023 05:36 Inactive
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (1f5f88c) 71.15% compared to head (49d475e) 71.19%.

❗ Current head 49d475e differs from pull request most recent head 1405a4a. Consider uploading reports for the commit 1405a4a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2364      +/-   ##
==========================================
+ Coverage   71.15%   71.19%   +0.04%     
==========================================
  Files         229      229              
  Lines        8052     8052              
  Branches     1731     1730       -1     
==========================================
+ Hits         5729     5733       +4     
+ Misses       1762     1760       -2     
+ Partials      561      559       -2     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Mar 20, 2023

Passing run #3250 ↗︎

0 176 0 0 Flakiness 0

Details:

Merge 49d475e into c799672...
Project: Glific Commit: 6193877b84 ℹ️
Status: Passed Duration: 27:47 💡
Started: Mar 20, 2023 5:46 AM Ended: Mar 20, 2023 6:13 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mdshamoon mdshamoon requested a review from kurund March 22, 2023 09:21
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-actions github-actions bot temporarily deployed to pull request March 23, 2023 18:10 Inactive
@kurund kurund merged commit 0bf520f into master Mar 23, 2023
@kurund kurund deleted the fix/babynama-issues branch March 23, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile enhancements | Babynama
2 participants