Improve platform responsiveness for smaller screens #2350
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2350 +/- ##
==========================================
+ Coverage 71.19% 71.33% +0.13%
==========================================
Files 229 229
Lines 8052 8052
Branches 1730 1731 +1
==========================================
+ Hits 5733 5744 +11
+ Misses 1760 1741 -19
- Partials 559 567 +8
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
10 failed tests on run #3247 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Login page > Successful login |
Output
Screenshots
|
|
chat/Chat.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Chats > should conatin help menu in sidebar |
Output
Screenshots
|
|
notification/notification.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Notification list > should show Notifications in sidebar |
Output
Screenshots
|
|
roles/staff/chat/Chat.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Role - Staff - Chats > should have only chat menu |
Output
Screenshots
|
|
roles/staff/chat/ChatCollection.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Role - Staff - ChatCollection > should send the message to collection |
Output
Screenshots
|
|
The first 5 failed specs are shown, see all 10 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
…to feature/support-smaller-screens
| @@ -245,7 +245,7 @@ export const List = ({ | |||
| filterItemsQuery, | |||
| { | |||
| variables: filterPayload(), | |||
| fetchPolicy: 'cache-and-network', | |||
There was a problem hiding this comment.
Not sure how this is related to responsiveness?
There was a problem hiding this comment.
When we are opening or closing the sideDrawer this query is getting called again if we have this fetch-policy. I have checked multiple scenarios like adding deleting or editing a list item and there are no issues caused by changing this policy.
| @@ -259,7 +259,7 @@ export const List = ({ | |||
|
|
|||
| useEffect(() => { | |||
| refetchCount(); | |||
| }, [filterPayload, searchVal, filters]); | |||
There was a problem hiding this comment.
refetchcount was getting called even if the filterPayload and filter were not changing while closing or opening the side drawer. Removing these doesnt seem to cause any issue with the existing features.
Summary
Improve platform responsiveness for smaller screens