Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags cleanup from codebase #2299

Merged
merged 7 commits into from
Jan 16, 2023
Merged

Tags cleanup from codebase #2299

merged 7 commits into from
Jan 16, 2023

Conversation

mdshamoon
Copy link
Member

Summary

Tags cleanup from codebase

@cypress
Copy link

cypress bot commented Jan 9, 2023



Test summary

172 0 0 0Flakiness 2


Run details

Project Glific
Status Passed
Commit 9bfb6b7 ℹ️
Started Jan 10, 2023 10:29 AM
Ended Jan 10, 2023 10:46 AM
Duration 17:46 💡
OS Linux Ubuntu - 22.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Flakiness

roles/staff/chat/Chat.spec.ts Flakiness
1 Role - Staff - Chats > Send attachment - Sticker
template/HSMTemplate.spec.ts Flakiness
1 HSM Template > should show not show sticker option

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 70.09% // Head: 69.84% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (aefbb8b) compared to base (feb9fb0).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2299      +/-   ##
==========================================
- Coverage   70.09%   69.84%   -0.25%     
==========================================
  Files         239      233       -6     
  Lines        8101     7985     -116     
  Branches     1741     1724      -17     
==========================================
- Hits         5678     5577     -101     
+ Misses       1842     1833       -9     
+ Partials      581      575       -6     
Impacted Files Coverage Δ
src/components/UI/ListIcon/ListIcon.tsx 100.00% <ø> (ø)
src/config/menu.ts 80.00% <ø> (ø)
...onversations/ChatConversation/ChatConversation.tsx 60.60% <ø> (-3.04%) ⬇️
...ChatConversations/ChatConversations.test.helper.ts 100.00% <ø> (ø)
...ners/Chat/ChatMessages/ChatMessage/ChatMessage.tsx 92.92% <ø> (ø)
...tainers/Chat/ChatSubscription/ChatSubscription.tsx 21.34% <0.00%> (-0.31%) ⬇️
src/containers/Form/FormLayout.tsx 47.43% <ø> (-5.13%) ⬇️
src/containers/List/List.tsx 82.01% <ø> (+3.70%) ⬆️
src/containers/Profile/Contact/ContactProfile.tsx 71.42% <ø> (ø)
src/containers/Profile/Profile.tsx 36.06% <ø> (-38.18%) ⬇️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Jan 10, 2023

@github-actions github-actions bot temporarily deployed to pull request January 10, 2023 10:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 10, 2023 10:21 Inactive
@mdshamoon mdshamoon self-assigned this Jan 13, 2023
@mdshamoon mdshamoon requested a review from kurund January 13, 2023 05:23
@github-actions github-actions bot temporarily deployed to pull request January 13, 2023 11:06 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 16, 2023 22:14 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Glad we finally got this done.

@kurund kurund merged commit d9c3741 into master Jan 16, 2023
@kurund kurund deleted the cleanup/tags branch January 16, 2023 22:28
@mdshamoon mdshamoon linked an issue Jan 17, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup commented tags code from the codebase
2 participants