Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor ui fixes #2173

Merged
merged 2 commits into from
Oct 5, 2022
Merged

minor ui fixes #2173

merged 2 commits into from
Oct 5, 2022

Conversation

kurund
Copy link
Contributor

@kurund kurund commented Oct 3, 2022

Minor UI fixes to bulk contact update screen

@kurund kurund requested a review from mdshamoon October 3, 2022 17:54
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

@github-actions github-actions bot temporarily deployed to pull request October 3, 2022 17:58 Inactive
@cypress
Copy link

cypress bot commented Oct 3, 2022



Test summary

177 3 0 0Flakiness 1


Run details

Project Glific
Status Failed
Commit 3d31cf5 ℹ️
Started Oct 4, 2022 6:03 PM
Ended Oct 4, 2022 6:30 PM
Duration 26:24 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Failures

contactBar/ContactBar.spec.ts Failed
1 Contact bar > should block contact
roles/staff/contactBar/ContactBar.spec.ts Failed
1 Role - Staff - Contact bar > should block contact
staffmanagement/StaffManagement.spec.ts Failed
1 Staff Management > should redirect to chat screen

Flakiness

cypress/integration/roles/staff/contactBar/ContactBar.spec.ts Flakiness
1 Role - Staff - Contact bar > should clear conversations

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@github-actions github-actions bot temporarily deployed to pull request October 4, 2022 17:56 Inactive
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 74.87% // Head: 74.87% // No change to project coverage 👍

Coverage data is based on head (f49200e) compared to base (dd57679).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2173   +/-   ##
=======================================
  Coverage   74.87%   74.87%           
=======================================
  Files         223      223           
  Lines        7872     7872           
  Branches     1706     1706           
=======================================
  Hits         5894     5894           
  Misses       1411     1411           
  Partials      567      567           
Impacted Files Coverage Δ
.../AdminContactManagement/AdminContactManagement.tsx 23.68% <ø> (ø)
src/containers/Profile/Profile.tsx 84.61% <0.00%> (-3.08%) ⬇️
src/components/simulator/Simulator.tsx 59.18% <0.00%> (-0.52%) ⬇️
src/containers/Template/Form/Template.tsx 36.95% <0.00%> (-0.28%) ⬇️
...rs/InteractiveMessage/InteractiveMessage.helper.ts 70.80% <0.00%> (+2.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kurund
Copy link
Contributor Author

kurund commented Oct 4, 2022

@mdshamoon

Ready for your review.

Copy link
Member

@mdshamoon mdshamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mdshamoon mdshamoon merged commit 56bb6ee into master Oct 5, 2022
@mdshamoon mdshamoon deleted the ui-fixes branch October 5, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants