Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lets not make a global change for checkbox background #2137

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Conversation

mdshamoon
Copy link
Member

Summary

Lets not make a global change for checkbox background as it is affecting other areas.

We can extend the checkbox on organization registration page to use in other places where white background is needed.

@mdshamoon mdshamoon self-assigned this Aug 29, 2022
@mdshamoon mdshamoon linked an issue Aug 29, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Aug 29, 2022

@github-actions github-actions bot temporarily deployed to pull request August 29, 2022 05:55 Inactive
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #2137 (ddb6c15) into master (94aebec) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2137      +/-   ##
==========================================
+ Coverage   74.98%   75.11%   +0.12%     
==========================================
  Files         221      221              
  Lines        7752     7752              
  Branches     1684     1684              
==========================================
+ Hits         5813     5823      +10     
+ Misses       1383     1370      -13     
- Partials      556      559       +3     
Impacted Files Coverage Δ
src/components/UI/ListIcon/ListIcon.tsx 88.88% <0.00%> (-11.12%) ⬇️
...nents/UI/Layout/Navigation/SideMenus/SideMenus.tsx 87.50% <0.00%> (-4.17%) ⬇️
src/containers/Trigger/Trigger.tsx 77.68% <0.00%> (-4.14%) ⬇️
src/containers/Template/Form/Template.tsx 37.22% <0.00%> (+0.27%) ⬆️
src/components/simulator/Simulator.tsx 59.69% <0.00%> (+0.51%) ⬆️
src/containers/Flow/FlowList/FlowList.tsx 81.66% <0.00%> (+3.33%) ⬆️
...c/containers/NotificationList/NotificationList.tsx 84.74% <0.00%> (+3.38%) ⬆️
src/components/UI/Form/TimePicker/TimePicker.tsx 84.21% <0.00%> (+5.26%) ⬆️
src/common/utils.ts 72.15% <0.00%> (+12.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cypress
Copy link

cypress bot commented Aug 29, 2022



Test summary

167 0 0 0Flakiness 0


Run details

Project Glific
Status Passed
Commit d9e32e6 ℹ️
Started Aug 29, 2022 6:03 AM
Ended Aug 29, 2022 6:23 AM
Duration 19:29 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@github-actions github-actions bot temporarily deployed to pull request August 30, 2022 22:35 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kurund kurund merged commit 73fd98d into master Aug 30, 2022
@kurund kurund deleted the bug/checkbox-ui branch August 30, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consulting Screen: Current day UI bug
2 participants