Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #204

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Code cleanup #204

merged 2 commits into from
Jul 17, 2020

Conversation

rathorevaibhav
Copy link
Contributor

@rathorevaibhav rathorevaibhav commented Jul 17, 2020 •
edited
Loading

Summary

Further code cleanups based on CodeBeat reports

Note: mocks in ChatMesssage.test are not being used. I've commented them as there is some duplication in ChatConversation.test.

@rathorevaibhav rathorevaibhav self-assigned this Jul 17, 2020
@rathorevaibhav rathorevaibhav added this to the v0.2 milestone Jul 17, 2020
@rathorevaibhav rathorevaibhav requested a review from kurund July 17, 2020 12:19
@rathorevaibhav rathorevaibhav marked this pull request as ready for review July 17, 2020 12:19
@rathorevaibhav rathorevaibhav linked an issue Jul 17, 2020 that may be closed by this pull request
Code cleanup and refactoring based on CodeBeat #197
Closed
kurund
kurund approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kurund kurund merged commit 8f44dbb into master Jul 17, 2020
@kurund kurund deleted the codebeat/code-cleanup branch July 17, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurund kurund kurund approved these changes

Assignees

@rathorevaibhav rathorevaibhav

Labels
None yet
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.

Code cleanup and refactoring based on CodeBeat
2 participants
@rathorevaibhav @kurund