Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor validation enhancements in interactive messages #2020

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

mdshamoon
Copy link
Member

@mdshamoon mdshamoon commented Apr 12, 2022

Summary

Minor validation enhancements in interactive messages

@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request April 12, 2022 10:43 Inactive
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #2020 (60a89f8) into master (c939f59) will increase coverage by 0.34%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master    #2020      +/-   ##
==========================================
+ Coverage   75.82%   76.17%   +0.34%     
==========================================
  Files         216      216              
  Lines        7501     7500       -1     
  Branches     1619     1621       +2     
==========================================
+ Hits         5688     5713      +25     
+ Misses       1285     1263      -22     
+ Partials      528      524       -4     
Impacted Files Coverage Δ
...eMessage/InteractiveOptions/InteractiveOptions.tsx 92.85% <ø> (ø)
...veMessage/InteractiveOptions/ListReplyTemplate.tsx 92.00% <50.00%> (-2.12%) ⬇️
...atMessages/ListReplyTemplate/ListReplyTemplate.tsx 97.67% <100.00%> (ø)
src/containers/Form/FormLayout.tsx 63.84% <0.00%> (+0.93%) ⬆️
...ntainers/InteractiveMessage/InteractiveMessage.tsx 68.33% <0.00%> (+2.66%) ⬆️
...rs/InteractiveMessage/InteractiveMessage.helper.ts 69.92% <0.00%> (+9.02%) ⬆️
src/containers/Auth/Login/Login.tsx 91.89% <0.00%> (+13.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c939f59...60a89f8. Read the comment docs.

@cypress
Copy link

cypress bot commented Apr 12, 2022



Test summary

180 0 0 0Flakiness 1


Run details

Project Glific
Status Passed
Commit d9d03ad ℹ️
Started Apr 12, 2022 10:50 AM
Ended Apr 12, 2022 11:12 AM
Duration 21:27 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/roles/staff/contactBar/ContactBar.spec.ts Flakiness
1 Role - Staff - Contact bar > should block contact

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mdshamoon mdshamoon self-assigned this Apr 12, 2022
@mdshamoon mdshamoon merged commit 46b7c66 into master Apr 12, 2022
@mdshamoon mdshamoon deleted the fixes/validations-and-enhancements branch April 12, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant