Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanups and refactoring #198

Merged
merged 8 commits into from
Jul 16, 2020
Merged

Code cleanups and refactoring #198

merged 8 commits into from
Jul 16, 2020

Conversation

rathorevaibhav
Copy link
Contributor

Summary

Code cleanups based on CodeBeat feedbacks

@rathorevaibhav rathorevaibhav self-assigned this Jul 15, 2020
@rathorevaibhav rathorevaibhav linked an issue Jul 15, 2020 that may be closed by this pull request
@rathorevaibhav rathorevaibhav requested a review from kurund July 16, 2020 07:12
@rathorevaibhav rathorevaibhav marked this pull request as ready for review July 16, 2020 07:12
@rathorevaibhav rathorevaibhav removed the request for review from kurund July 16, 2020 07:18
@rathorevaibhav rathorevaibhav requested a review from kurund July 16, 2020 10:43
}
}

function formatList(tags: Array<any>) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tags reference should be removed from this.

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kurund kurund merged commit 1d5fcb2 into master Jul 16, 2020
@kurund kurund deleted the feature/common-list-component branch July 16, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants