Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/authentication #192

Merged
merged 27 commits into from
Jul 14, 2020
Merged

Feature/authentication #192

merged 27 commits into from
Jul 14, 2020

Conversation

rathorevaibhav
Copy link
Contributor

@rathorevaibhav rathorevaibhav commented Jul 14, 2020

Summary

  1. Authentication module.
  2. Public and private routes

Test Plan

Test cases added

Note

One test case in App.test.tsx is failing in GitHub CI due to an error related to Websocket. I've commented it until I find a suitable fix for that.
image

@rathorevaibhav rathorevaibhav marked this pull request as ready for review July 14, 2020 11:10
@rathorevaibhav rathorevaibhav requested a review from kurund July 14, 2020 11:10
@rathorevaibhav rathorevaibhav self-assigned this Jul 14, 2020
@rathorevaibhav rathorevaibhav added this to the v0.2 milestone Jul 14, 2020
@@ -0,0 +1,6 @@
import React from 'react';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context is kind of special and different from other files in this folder. So should we create "src/context" folder and move this there?

@rathorevaibhav rathorevaibhav linked an issue Jul 14, 2020 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #192 into master will decrease coverage by 0.87%.
The diff coverage is 48.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   74.85%   73.98%   -0.88%     
==========================================
  Files          45       46       +1     
  Lines         859      884      +25     
  Branches      166      171       +5     
==========================================
+ Hits          643      654      +11     
- Misses        140      149       +9     
- Partials       76       81       +5     
Impacted Files Coverage Δ
src/components/pages/Registration/Registration.tsx 93.54% <ø> (ø)
src/components/pages/ConfirmOTP/ConfirmOTP.tsx 71.42% <33.33%> (-6.35%) ⬇️
src/App.tsx 50.00% <36.36%> (-50.00%) ⬇️
...nts/UI/Layout/Navigation/SideDrawer/SideDrawer.tsx 54.16% <37.50%> (-8.34%) ⬇️
src/common/constants.ts 100.00% <100.00%> (ø)
src/common/session.ts 100.00% <100.00%> (ø)
src/components/pages/Login/Login.tsx 93.02% <100.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30d6ec1...f7472e0. Read the comment docs.

@kurund kurund merged commit b70d45b into master Jul 14, 2020
@kurund kurund deleted the feature/Authentication branch July 14, 2020 16:47
claalmve added a commit that referenced this pull request Jul 14, 2020
This reverts commit b70d45b, reversing
changes made to 30d6ec1.
claalmve added a commit that referenced this pull request Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement authentication for the project
3 participants