-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/authentication #192
Conversation
src/common/session.ts
Outdated
@@ -0,0 +1,6 @@ | |||
import React from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Context is kind of special and different from other files in this folder. So should we create "src/context" folder and move this there?
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
==========================================
- Coverage 74.85% 73.98% -0.88%
==========================================
Files 45 46 +1
Lines 859 884 +25
Branches 166 171 +5
==========================================
+ Hits 643 654 +11
- Misses 140 149 +9
- Partials 76 81 +5
Continue to review full report at Codecov.
|
…ation"" This reverts commit 92d69b6.
Summary
Test Plan
Test cases added
Note
One test case in App.test.tsx is failing in GitHub CI due to an error related to Websocket. I've commented it until I find a suitable fix for that.
![image](https://user-images.githubusercontent.com/12053186/87419471-2d898980-c5f1-11ea-89e4-d431b225de73.png)