Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always show correct simulator name #1897

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

kurund
Copy link
Contributor

@kurund kurund commented Feb 6, 2022

No description provided.

@kurund kurund linked an issue Feb 6, 2022 that may be closed by this pull request
@kurund kurund requested a review from mdshamoon February 6, 2022 15:50
@github-actions
Copy link

github-actions bot commented Feb 6, 2022

@github-actions github-actions bot temporarily deployed to pull request February 6, 2022 15:55 Inactive
@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #1897 (1d1b0fb) into master (a6f739e) will increase coverage by 0.18%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1897      +/-   ##
==========================================
+ Coverage   76.62%   76.81%   +0.18%     
==========================================
  Files         212      212              
  Lines        7282     7285       +3     
  Branches     1560     1561       +1     
==========================================
+ Hits         5580     5596      +16     
+ Misses       1203     1190      -13     
  Partials      499      499              
Impacted Files Coverage Δ
src/common/utils.ts 60.93% <33.33%> (-1.36%) ⬇️
src/containers/List/List.tsx 84.73% <0.00%> (-1.06%) ⬇️
...c/containers/NotificationList/NotificationList.tsx 84.74% <0.00%> (+3.38%) ⬆️
...rs/InteractiveMessage/InteractiveMessage.helper.ts 68.37% <0.00%> (+3.41%) ⬆️
src/containers/Profile/Profile.tsx 92.68% <0.00%> (+4.87%) ⬆️
src/containers/Auth/Login/Login.tsx 83.78% <0.00%> (+24.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f739e...1d1b0fb. Read the comment docs.

@cypress
Copy link

cypress bot commented Feb 6, 2022



Test summary

180 0 0 0Flakiness 4


Run details

Project Glific
Status Passed
Commit 2561dc0 ℹ️
Started Feb 6, 2022 4:03 PM
Ended Feb 6, 2022 4:29 PM
Duration 25:46 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Flakiness

auth/Logout.spec.ts Flakiness
1 Logout > should logout correctly
chat/Chat.spec.ts Flakiness
1 Chats > Send attachment - Audio
interactiveMessage/InteractiveMessage.spec.ts Flakiness
1 Interactive message quick reply > should create new quick reply
roles/staff/chat/Chat.spec.ts Flakiness
1 Role - Staff - Chats > Send attachment - Sticker

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mdshamoon mdshamoon merged commit e20d47b into master Feb 7, 2022
@mdshamoon mdshamoon deleted the simulator-name-fixes branch February 7, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the correct name for simulator
2 participants