Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed type errors by stricter absinthe check #1865

Merged
merged 4 commits into from
Jan 20, 2022
Merged

Fixed type errors by stricter absinthe check #1865

merged 4 commits into from
Jan 20, 2022

Conversation

mdshamoon
Copy link
Member

@mdshamoon mdshamoon commented Jan 20, 2022

Summary

Fixed type errors by strict absinthe check.

@github-actions
Copy link

github-actions bot commented Jan 20, 2022

@github-actions github-actions bot temporarily deployed to pull request January 20, 2022 05:58 Inactive
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #1865 (46b603c) into master (4001c64) will increase coverage by 0.37%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1865      +/-   ##
==========================================
+ Coverage   76.28%   76.66%   +0.37%     
==========================================
  Files         212      212              
  Lines        7231     7237       +6     
  Branches     1556     1556              
==========================================
+ Hits         5516     5548      +32     
+ Misses       1210     1187      -23     
+ Partials      505      502       -3     
Impacted Files Coverage Δ
src/graphql/mutations/Flow.ts 100.00% <ø> (ø)
src/graphql/mutations/InteractiveMessage.ts 100.00% <ø> (ø)
src/graphql/mutations/Trigger.ts 100.00% <ø> (ø)
src/graphql/queries/Search.ts 100.00% <ø> (ø)
src/components/UI/Form/TimePicker/TimePicker.tsx 77.77% <66.66%> (-2.23%) ⬇️
...ntainers/SettingList/Organisation/Organisation.tsx 74.78% <100.00%> (+0.67%) ⬆️
src/containers/SettingList/Billing/Billing.tsx 67.71% <0.00%> (-0.79%) ⬇️
src/containers/Form/FormLayout.tsx 64.01% <0.00%> (+0.93%) ⬆️
src/containers/List/List.tsx 85.78% <0.00%> (+1.05%) ⬆️
...ntainers/InteractiveMessage/InteractiveMessage.tsx 67.68% <0.00%> (+2.72%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e3f3cb...46b603c. Read the comment docs.

@mdshamoon mdshamoon linked an issue Jan 20, 2022 that may be closed by this pull request
@cypress
Copy link

cypress bot commented Jan 20, 2022



Test summary

180 0 0 0Flakiness 1


Run details

Project Glific
Status Passed
Commit 5e722c4 ℹ️
Started Jan 20, 2022 11:31 AM
Ended Jan 20, 2022 11:51 AM
Duration 19:40 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/auth/Logout.spec.ts Flakiness
1 Logout > should logout correctly

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@github-actions github-actions bot temporarily deployed to pull request January 20, 2022 06:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 20, 2022 08:48 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 20, 2022 11:25 Inactive
@mdshamoon mdshamoon merged commit f6acf93 into master Jan 20, 2022
@mdshamoon mdshamoon deleted the update/types branch January 20, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error due to strict absinthe check from backend
1 participant