Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added restart option in simulator #1860

Merged
merged 7 commits into from
Jan 25, 2022
Merged

Conversation

mdshamoon
Copy link
Member

Summary

Added restart option in simulator

@github-actions
Copy link

github-actions bot commented Jan 18, 2022

@github-actions github-actions bot temporarily deployed to pull request January 18, 2022 14:03 Inactive
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #1860 (5e0a15b) into master (f6acf93) will increase coverage by 0.40%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1860      +/-   ##
==========================================
+ Coverage   76.34%   76.74%   +0.40%     
==========================================
  Files         212      212              
  Lines        7237     7246       +9     
  Branches     1556     1563       +7     
==========================================
+ Hits         5525     5561      +36     
+ Misses       1209     1185      -24     
+ Partials      503      500       -3     
Impacted Files Coverage Δ
src/components/floweditor/FlowEditor.tsx 74.43% <ø> (ø)
src/mocks/Simulator.tsx 100.00% <ø> (ø)
src/components/simulator/Simulator.tsx 63.78% <87.50%> (+0.45%) ⬆️
src/containers/SettingList/Billing/Billing.tsx 67.71% <0.00%> (-0.79%) ⬇️
...ntainers/Chat/ChatMessages/ChatInput/ChatInput.tsx 80.12% <0.00%> (ø)
...ners/Chat/ChatMessages/ChatMessage/ChatMessage.tsx 92.98% <0.00%> (ø)
...onversations/ChatConversation/ChatConversation.tsx 73.91% <0.00%> (ø)
...onversations/ConversationList/ConversationList.tsx 68.71% <0.00%> (ø)
src/components/UI/Form/Checkbox/Checkbox.tsx 92.85% <0.00%> (+0.54%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6acf93...5e0a15b. Read the comment docs.

@cypress
Copy link

cypress bot commented Jan 18, 2022



Test summary

180 0 0 0Flakiness 3


Run details

Project Glific
Status Passed
Commit 4e58b64 ℹ️
Started Jan 25, 2022 9:16 AM
Ended Jan 25, 2022 9:39 AM
Duration 22:58 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Flakiness

auth/Logout.spec.ts Flakiness
1 Logout > should logout correctly
staff/Profile.spec.ts Flakiness
1 Profile > should have form validation
2 Profile > should not submit empty form

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mdshamoon mdshamoon linked an issue Jan 20, 2022 that may be closed by this pull request
@github-actions github-actions bot temporarily deployed to pull request January 21, 2022 10:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 24, 2022 08:03 Inactive
@mdshamoon mdshamoon requested a review from kurund January 24, 2022 09:06
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-actions github-actions bot temporarily deployed to pull request January 25, 2022 09:08 Inactive
@mdshamoon mdshamoon merged commit 382bea0 into master Jan 25, 2022
@mdshamoon mdshamoon deleted the feature/restart-simulator branch January 25, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to restart simulator
2 participants