Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui fixes #1691

Merged
merged 1 commit into from
Oct 7, 2021
Merged

ui fixes #1691

merged 1 commit into from
Oct 7, 2021

Conversation

kurund
Copy link
Contributor

@kurund kurund commented Oct 6, 2021

No description provided.

@kurund kurund linked an issue Oct 6, 2021 that may be closed by this pull request
@kurund kurund requested a review from mdshamoon October 6, 2021 21:45
@cypress
Copy link

cypress bot commented Oct 6, 2021



Test summary

180 0 0 0Flakiness 5


Run details

Project Glific
Status Passed
Commit cc73ff2 ℹ️
Started Oct 6, 2021 10:03 PM
Ended Oct 6, 2021 10:32 PM
Duration 29:32 💡
OS Linux Ubuntu - 20.04
Browser Electron 91

View run in Cypress Dashboard ➡️


Flakiness

flow/Flow.spec.ts Flakiness
1 Flow > should delete the copy Flow
2 Flow > should delete previous created flow
staffmanagement/StaffManagement.spec.ts Flakiness
1 Staff Management > should remove collection from staff
2 Staff Management > should redirect to edit screen
3 Staff Management > should delete collection

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #1691 (6bc716f) into master (9576e4e) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1691      +/-   ##
==========================================
- Coverage   77.32%   77.26%   -0.06%     
==========================================
  Files         206      206              
  Lines        7007     7007              
  Branches     1500     1500              
==========================================
- Hits         5418     5414       -4     
- Misses       1119     1121       +2     
- Partials      470      472       +2     
Impacted Files Coverage Δ
src/containers/Auth/Login/Login.tsx 55.00% <0.00%> (-17.50%) ⬇️
src/common/utils.ts 59.18% <0.00%> (-16.33%) ⬇️
src/containers/Flow/FlowList/FlowList.tsx 82.69% <0.00%> (-3.85%) ⬇️
src/containers/Template/Form/HSM/HSM.tsx 72.88% <0.00%> (-1.70%) ⬇️
src/containers/Form/FormLayout.tsx 60.95% <0.00%> (-1.43%) ⬇️
src/containers/Template/Form/Template.tsx 35.94% <0.00%> (-0.28%) ⬇️
...ntainers/InteractiveMessage/InteractiveMessage.tsx 59.40% <0.00%> (+1.98%) ⬆️
src/containers/Profile/Profile.tsx 95.12% <0.00%> (+4.87%) ⬆️
...rs/InteractiveMessage/InteractiveMessage.helper.ts 79.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9576e4e...6bc716f. Read the comment docs.

@mdshamoon mdshamoon merged commit 15570a0 into master Oct 7, 2021
@mdshamoon mdshamoon deleted the contact-fields-fixes branch October 7, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact Fields Screen
2 participants