-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed draft js formatting issues #1690
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Codecov Report
@@ Coverage Diff @@
## master #1690 +/- ##
==========================================
+ Coverage 77.13% 77.34% +0.20%
==========================================
Files 206 206
Lines 7007 7001 -6
Branches 1500 1507 +7
==========================================
+ Hits 5405 5415 +10
+ Misses 1134 1110 -24
- Partials 468 476 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's fix the errors before merging this.
@kurund I was keeping it like how WhatsApp does it but yeah I think this can confuse people. Let me remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdshamoon
PR looks good!
Working as expected and all the reported issues are fixed.
Good to merge once CI passes
Summary
Added decorator for bold and removed markdown formatting internally.
Formattting done now will now be similar to whatsApp