Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes required in dialogboxes in floweditor #1653

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

mdshamoon
Copy link
Member

Summary

Added changes that are required in dialog boxes in floweditor.

Test Plan

Added

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #1653 (a858d2e) into master (7530b3e) will increase coverage by 0.11%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1653      +/-   ##
==========================================
+ Coverage   78.47%   78.59%   +0.11%     
==========================================
  Files         205      205              
  Lines        6829     6839      +10     
  Branches     1440     1443       +3     
==========================================
+ Hits         5359     5375      +16     
+ Misses       1032     1026       -6     
  Partials      438      438              
Impacted Files Coverage Δ
src/components/floweditor/FlowEditor.tsx 76.50% <33.33%> (-1.14%) ⬇️
src/components/UI/DialogBox/DialogBox.tsx 95.23% <77.77%> (-4.77%) ⬇️
src/components/UI/Form/TimePicker/TimePicker.tsx 86.66% <0.00%> (-6.67%) ⬇️
src/containers/Trigger/Trigger.tsx 93.33% <0.00%> (+16.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7530b3e...a858d2e. Read the comment docs.

@cypress
Copy link

cypress bot commented Sep 13, 2021



Test summary

164 0 0 0Flakiness 1


Run details

Project Glific
Status Passed
Commit 0c527bc ℹ️
Started Sep 13, 2021 10:05 AM
Ended Sep 13, 2021 10:28 AM
Duration 23:50 💡
OS Linux Ubuntu - 20.04
Browser Electron 91

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/staffmanagement/StaffManagement.spec.ts Flakiness
1 Staff Management > should save edit screen

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mdshamoon mdshamoon linked an issue Sep 14, 2021 that may be closed by this pull request
@mdshamoon mdshamoon self-assigned this Sep 14, 2021
@mdshamoon mdshamoon requested a review from kurund September 14, 2021 07:48
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@kurund kurund merged commit 975b0e7 into master Sep 16, 2021
@kurund kurund deleted the feature/flow-dialog-update branch September 16, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floweditor changes
2 participants