Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed headers position to fixed #1583

Merged
merged 12 commits into from
Nov 3, 2021
Merged

Changed headers position to fixed #1583

merged 12 commits into from
Nov 3, 2021

Conversation

mdshamoon
Copy link
Member

Summary

Changed headers position to fixed

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #1583 (6314320) into master (5803c33) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1583      +/-   ##
==========================================
+ Coverage   77.16%   77.37%   +0.20%     
==========================================
  Files         206      206              
  Lines        7034     7045      +11     
  Branches     1519     1521       +2     
==========================================
+ Hits         5428     5451      +23     
+ Misses       1123     1112      -11     
+ Partials      483      482       -1     
Impacted Files Coverage Δ
...ct/CollectionContactList/CollectionContactList.tsx 100.00% <ø> (ø)
src/containers/List/List.tsx 84.40% <100.00%> (+0.34%) ⬆️
src/common/utils.ts 59.18% <0.00%> (-16.33%) ⬇️
src/components/UI/Form/TimePicker/TimePicker.tsx 86.66% <0.00%> (-6.67%) ⬇️
src/containers/Flow/FlowList/FlowList.tsx 82.69% <0.00%> (-3.85%) ⬇️
...iners/Consulting/ConsultingList/ConsultingList.tsx 100.00% <0.00%> (ø)
src/containers/Template/Form/Template.tsx 36.48% <0.00%> (+0.27%) ⬆️
src/components/simulator/Simulator.tsx 67.42% <0.00%> (+0.57%) ⬆️
src/containers/Form/FormLayout.tsx 62.38% <0.00%> (+1.42%) ⬆️
...rs/InteractiveMessage/InteractiveMessage.helper.ts 79.00% <0.00%> (+4.00%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5803c33...6314320. Read the comment docs.

@cypress
Copy link

cypress bot commented Aug 9, 2021



Test summary

180 0 0 0Flakiness 1


Run details

Project Glific
Status Passed
Commit ec4ff30 ℹ️
Started Nov 2, 2021 12:15 PM
Ended Nov 2, 2021 12:42 PM
Duration 27:12 💡
OS Linux Ubuntu - 20.04
Browser Electron 93

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/template/SpeedSend.spec.ts Flakiness
1 Speed Send > should edit speed send

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mdshamoon mdshamoon linked an issue Aug 12, 2021 that may be closed by this pull request
@mdshamoon mdshamoon self-assigned this Aug 12, 2021
@mdshamoon mdshamoon added the on hold This is on hold label Sep 14, 2021
@mdshamoon mdshamoon removed the on hold This is on hold label Sep 20, 2021
@mdshamoon mdshamoon requested a review from kurund September 29, 2021 10:23
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdshamoon

The pager footer is sticky and working as expected. There is a test failure and looks related. Please check.

@kurund
Copy link
Contributor

kurund commented Sep 29, 2021

I have triggered a rerun for tests.

@mdshamoon
Copy link
Member Author

@kurund fixed the test case in cypress

@mdshamoon mdshamoon requested a review from kurund November 3, 2021 10:08
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kurund kurund merged commit 48b6183 into master Nov 3, 2021
@kurund kurund deleted the feature/header-sticky branch November 3, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the page headers and titles sticky
2 participants