Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning cleanup #1574

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Warning cleanup #1574

merged 2 commits into from
Aug 4, 2021

Conversation

kurund
Copy link
Contributor

@kurund kurund commented Aug 3, 2021

Summary

  • Clean up compilation warnings

@kurund kurund requested a review from mdshamoon August 3, 2021 21:48
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #1574 (3f9a8a9) into master (ab1645b) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
- Coverage   77.57%   77.41%   -0.17%     
==========================================
  Files         204      204              
  Lines        6813     6813              
  Branches     1410     1410              
==========================================
- Hits         5285     5274      -11     
- Misses       1088     1099      +11     
  Partials      440      440              
Impacted Files Coverage Δ
src/containers/Flow/FlowList/FlowList.tsx 85.71% <100.00%> (ø)
src/context/session.ts 100.00% <100.00%> (ø)
src/services/AuthService.tsx 64.48% <100.00%> (ø)
src/containers/Trigger/Trigger.tsx 77.33% <0.00%> (-16.00%) ⬇️
src/components/UI/Form/TimePicker/TimePicker.tsx 93.33% <0.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab1645b...3f9a8a9. Read the comment docs.

@cypress
Copy link

cypress bot commented Aug 3, 2021



Test summary

176 1 0 0Flakiness 11


Run details

Project Glific
Status Failed
Commit 64bdffd ℹ️
Started Aug 3, 2021 10:02 PM
Ended Aug 3, 2021 10:36 PM
Duration 33:57 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Failures

cypress/integration/flow/Flow.spec.ts Failed
1 Flow > should create new Flow without keyword

Flakiness

chat/Chat.spec.ts Flakiness
1 Chats > Send attachment - Image
2 Chats > Send attachment - Audio
3 Chats > Send attachment - Video
4 Chats > Send attachment - Document
contactBar/ContactBar.spec.ts Flakiness
1 Contact bar > should create new collection
This comment includes only the first 5 flaky tests. See all 11 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mdshamoon mdshamoon merged commit ca3a741 into master Aug 4, 2021
@mdshamoon mdshamoon deleted the warning-cleanup branch August 4, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants