Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup and version update #1420

Merged
merged 2 commits into from
May 31, 2021
Merged

Code cleanup and version update #1420

merged 2 commits into from
May 31, 2021

Conversation

mdshamoon
Copy link
Member

Summary

  • Added loading on flows screen
  • Updated version

@mdshamoon mdshamoon force-pushed the code-cleanup/flows branch from 05785a2 to a2fadb9 Compare May 31, 2021 10:31
@mdshamoon mdshamoon force-pushed the code-cleanup/flows branch from a2fadb9 to a4787a2 Compare May 31, 2021 10:33
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #1420 (6106c65) into master (190223b) will decrease coverage by 9.32%.
The diff coverage is 47.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1420      +/-   ##
==========================================
- Coverage   86.02%   76.70%   -9.33%     
==========================================
  Files         193      185       -8     
  Lines        6305     5684     -621     
  Branches     1492     1176     -316     
==========================================
- Hits         5424     4360    -1064     
- Misses        773      939     +166     
- Partials      108      385     +277     
Impacted Files Coverage Δ
src/components/floweditor/FlowEditor.tsx 71.42% <43.75%> (-3.94%) ⬇️
...iners/Consulting/ConsultingList/ConsultingList.tsx 100.00% <100.00%> (ø)
src/services/ToastService.tsx 50.00% <0.00%> (-50.00%) ⬇️
src/containers/Template/Form/Template.tsx 40.83% <0.00%> (-34.91%) ⬇️
src/containers/Chat/Chat.tsx 55.76% <0.00%> (-33.12%) ⬇️
src/containers/Form/FormLayout.tsx 48.95% <0.00%> (-32.95%) ⬇️
src/containers/Search/Search.tsx 56.38% <0.00%> (-30.49%) ⬇️
src/containers/StaffManagement/StaffManagement.tsx 54.05% <0.00%> (-29.95%) ⬇️
src/components/UI/Pager/Pager.tsx 58.49% <0.00%> (-28.61%) ⬇️
src/containers/Template/List/Template.tsx 64.58% <0.00%> (-28.28%) ⬇️
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190223b...6106c65. Read the comment docs.

@cypress
Copy link

cypress bot commented May 31, 2021



Test summary

165 0 0 0Flakiness 2


Run details

Project Glific
Status Passed
Commit f856d8e ℹ️
Started May 31, 2021 10:46 AM
Ended May 31, 2021 11:08 AM
Duration 21:23 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Flakiness

flow/Flow.spec.ts Flakiness
1 Flow > should edit Flow
roles/staff/contactBar/ContactBar.spec.ts Flakiness
1 Role - Staff - Contact bar > should start a flow

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mdshamoon mdshamoon merged commit 24ef896 into master May 31, 2021
@mdshamoon mdshamoon deleted the code-cleanup/flows branch May 31, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant