added basic structure for extensions #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1402 +/- ##
==========================================
+ Coverage 76.01% 85.89% +9.87%
==========================================
Files 180 193 +13
Lines 5503 6266 +763
Branches 1139 1485 +346
==========================================
+ Hits 4183 5382 +1199
+ Misses 931 776 -155
+ Partials 389 108 -281
Continue to review full report at Codecov.
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
mdshamoon
reviewed
May 25, 2021
Comment on lines
93
to
120
| return ( | ||
| <Dialog | ||
| open={!!openDialog} | ||
| classes={{ | ||
| paper: styles.Dialogbox, | ||
| }} | ||
| > | ||
| <DialogContent classes={{ root: styles.DialogContent }}> | ||
| <FormLayout | ||
| {...queries} | ||
| match={match} | ||
| states={states} | ||
| setStates={setStates} | ||
| validationSchema={FormSchema} | ||
| listItemName="extension" | ||
| dialogMessage={dialogMessage} | ||
| formFields={formFields} | ||
| setPayload={setPayload} | ||
| redirectionLink="organizations" | ||
| listItem="Extension" | ||
| icon={flowIcon} | ||
| title={title} | ||
| type="Extension" | ||
| languageSupport={false} | ||
| /> | ||
| </DialogContent> | ||
| </Dialog> | ||
| ); |
There was a problem hiding this comment.
Suggested change
| return ( | |
| <Dialog | |
| open={!!openDialog} | |
| classes={{ | |
| paper: styles.Dialogbox, | |
| }} | |
| > | |
| <DialogContent classes={{ root: styles.DialogContent }}> | |
| <FormLayout | |
| {...queries} | |
| match={match} | |
| states={states} | |
| setStates={setStates} | |
| validationSchema={FormSchema} | |
| listItemName="extension" | |
| dialogMessage={dialogMessage} | |
| formFields={formFields} | |
| setPayload={setPayload} | |
| redirectionLink="organizations" | |
| listItem="Extension" | |
| icon={flowIcon} | |
| title={title} | |
| type="Extension" | |
| languageSupport={false} | |
| /> | |
| </DialogContent> | |
| </Dialog> | |
| ); | |
| return ( | |
| <> | |
| <OrganizationList /> | |
| <Dialog | |
| open={!!openDialog} | |
| classes={{ | |
| paper: styles.Dialogbox, | |
| }} | |
| > | |
| <DialogContent classes={{ root: styles.DialogContent }}> | |
| <FormLayout | |
| {...queries} | |
| match={match} | |
| states={states} | |
| setStates={setStates} | |
| validationSchema={FormSchema} | |
| listItemName="extension" | |
| dialogMessage={dialogMessage} | |
| formFields={formFields} | |
| setPayload={setPayload} | |
| redirectionLink="organizations" | |
| listItem="Extension" | |
| icon={flowIcon} | |
| title={title} | |
| type="Extension" | |
| languageSupport={false} | |
| /> | |
| </DialogContent> | |
| </Dialog> | |
| </> | |
| ); |
mdshamoon
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan