Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List all organizations #1345

Merged
merged 32 commits into from
May 5, 2021
Merged

List all organizations #1345

merged 32 commits into from
May 5, 2021

Conversation

shreesh1993
Copy link
Contributor

  • Added organization list
  • Now user can perform actions such as activate, approve and delete.
  • There will be a confirmation message while deleting in-active/invalid organization.

closes #1323

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #1345 (16ad8af) into master (881b729) will increase coverage by 0.21%.
The diff coverage is 82.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1345      +/-   ##
==========================================
+ Coverage   73.75%   73.97%   +0.21%     
==========================================
  Files         171      172       +1     
  Lines        5179     5271      +92     
  Branches     1074     1089      +15     
==========================================
+ Hits         3820     3899      +79     
- Misses        996     1005       +9     
- Partials      363      367       +4     
Impacted Files Coverage Δ
src/containers/StaffManagement/StaffManagement.tsx 54.05% <0.00%> (-2.29%) ⬇️
...gement/StaffManagementList/StaffManagementList.tsx 62.06% <0.00%> (-9.94%) ⬇️
src/context/role.ts 86.00% <0.00%> (-11.73%) ⬇️
src/containers/List/List.tsx 80.45% <92.85%> (+1.57%) ⬆️
...c/containers/OrganizationList/OrganizationList.tsx 96.42% <96.42%> (ø)
src/components/UI/DialogBox/DialogBox.tsx 100.00% <100.00%> (ø)
src/containers/List/List.test.helper.ts 100.00% <100.00%> (ø)
src/graphql/mutations/Organization.ts 100.00% <100.00%> (ø)
src/graphql/queries/Organization.ts 100.00% <100.00%> (ø)
src/mocks/Organization.tsx 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 881b729...16ad8af. Read the comment docs.

src/graphql/queries/Organization.ts Show resolved Hide resolved
src/assets/images/icons/Organisation-1.svg Outdated Show resolved Hide resolved
src/assets/images/icons/Organisation-2.svg Outdated Show resolved Hide resolved
@kurund kurund requested a review from mdshamoon May 2, 2021 13:27
Copy link
Member

@mdshamoon mdshamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change organization to organizations everywhere.

title: 'Organization',
path: '/organization',
type: 'staffManagement',
roles: ['Manager', 'Admin'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just give rights for admin only.

/**
* Removing organization list menu for non admin users
*/
if (user.name !== 'NGO Main Account') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user will be Saas Admin. Let's discuss and confirm in the call.

@mdshamoon mdshamoon self-requested a review May 5, 2021 05:21
@mdshamoon mdshamoon merged commit 1344c47 into master May 5, 2021
@mdshamoon mdshamoon deleted the list-all-organizations branch May 5, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listing of all organizations
3 participants