Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated collection info label #1234

Merged
merged 9 commits into from
Mar 31, 2021
Merged

Updated collection info label #1234

merged 9 commits into from
Mar 31, 2021

Conversation

DigneshGujarathi
Copy link
Contributor

Summary

Test Plan

@DigneshGujarathi DigneshGujarathi self-assigned this Mar 26, 2021
@DigneshGujarathi DigneshGujarathi added this to the Week of Mar 22nd milestone Mar 26, 2021
@DigneshGujarathi DigneshGujarathi linked an issue Mar 26, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #1234 (eb21752) into master (d456751) will increase coverage by 0.01%.
The diff coverage is 74.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1234      +/-   ##
==========================================
+ Coverage   72.99%   73.00%   +0.01%     
==========================================
  Files         161      161              
  Lines        4543     4582      +39     
  Branches      956      966      +10     
==========================================
+ Hits         3316     3345      +29     
- Misses        912      919       +7     
- Partials      315      318       +3     
Impacted Files Coverage Δ
...ainers/Chat/ChatMessages/ContactBar/ContactBar.tsx 86.02% <ø> (+0.73%) ⬆️
src/mocks/Collection.tsx 100.00% <ø> (ø)
src/containers/Chat/ChatMessages/ChatMessages.tsx 59.56% <45.45%> (-0.93%) ⬇️
...on/CollectionInformation/CollectionInformation.tsx 100.00% <100.00%> (ø)
...ners/Chat/ChatMessages/ChatMessage/ChatMessage.tsx 64.83% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d456751...eb21752. Read the comment docs.

@mdshamoon
Copy link
Member

mdshamoon commented Mar 30, 2021

Can we increase the test coverage some more so that it passes the codecov/poject

@mdshamoon mdshamoon merged commit 64804a3 into master Mar 31, 2021
@mdshamoon mdshamoon deleted the feature/group-information branch March 31, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature:Display group information
2 participants