Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for links with underscores #1215

Merged
merged 4 commits into from
Mar 24, 2021
Merged

Bug fixes for links with underscores #1215

merged 4 commits into from
Mar 24, 2021

Conversation

mdshamoon
Copy link
Member

Summary

Fixes for #1207

@mdshamoon mdshamoon added this to the Week of Mar 22nd milestone Mar 23, 2021
@mdshamoon mdshamoon self-assigned this Mar 23, 2021
@mdshamoon mdshamoon linked an issue Mar 23, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #1215 (47ad78c) into master (6d8410d) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1215      +/-   ##
==========================================
+ Coverage   72.04%   72.12%   +0.07%     
==========================================
  Files         156      156              
  Lines        4400     4405       +5     
  Branches      921      923       +2     
==========================================
+ Hits         3170     3177       +7     
+ Misses        922      921       -1     
+ Partials      308      307       -1     
Impacted Files Coverage Δ
src/common/RichEditor.tsx 57.14% <100.00%> (+6.12%) ⬆️
...atMessages/MessagesWithLinks/MessagesWithLinks.tsx 100.00% <100.00%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d8410d...47ad78c. Read the comment docs.

@DigneshGujarathi DigneshGujarathi self-requested a review March 24, 2021 05:11
Copy link
Contributor

@DigneshGujarathi DigneshGujarathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@DigneshGujarathi DigneshGujarathi merged commit 512e2c0 into master Mar 24, 2021
@DigneshGujarathi DigneshGujarathi deleted the bug/link-fix branch March 24, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken URL on the chat screen
2 participants