Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block simulator bug resolved #1197

Merged
merged 4 commits into from
Mar 19, 2021
Merged

Block simulator bug resolved #1197

merged 4 commits into from
Mar 19, 2021

Conversation

mdshamoon
Copy link
Member

Summary

Simulator contacts can't be blocked

Test Plan

Not needed.

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #1197 (8a4fe0c) into master (5155744) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1197   +/-   ##
=======================================
  Coverage   71.69%   71.70%           
=======================================
  Files         156      156           
  Lines        4395     4396    +1     
  Branches      920      920           
=======================================
+ Hits         3151     3152    +1     
  Misses        937      937           
  Partials      307      307           
Impacted Files Coverage Δ
src/containers/Chat/Chat.tsx 35.41% <ø> (ø)
src/common/constants.ts 100.00% <100.00%> (ø)
src/containers/Chat/ChatMessages/ChatMessages.tsx 59.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5155744...8a4fe0c. Read the comment docs.

@mdshamoon mdshamoon linked an issue Mar 19, 2021 that may be closed by this pull request
@mdshamoon mdshamoon added this to the Week of Mar 15th milestone Mar 19, 2021
@mdshamoon mdshamoon self-assigned this Mar 19, 2021
Copy link
Contributor

@DigneshGujarathi DigneshGujarathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@DigneshGujarathi DigneshGujarathi merged commit e3c476a into master Mar 19, 2021
@DigneshGujarathi DigneshGujarathi deleted the bug/block-simulator branch March 19, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable block a contact for simulator
2 participants