Consider ECONNRESET a non-temporary error. #287
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the
syslog
adapter treats ECONNRESET errors as "non-temporary", meaning that we immediately recreate the connection instead of first attempting to re-send the failed packets on the existing connection.It should be noted, there are cases ("under certain rapid connection setup/teardown conditions") where ECONNRESET can be a temporary error. See the Golang issue and associated commit.
However, it seems to me that of the real-world cases where an ECONNRESET is encountered, the great majority of the problems would be non-temporary. For example, Papertrail delivers an ECONNRESET after 15 minutes of inactivity, which indicates that they have permanently closed the connection and we need to open a new one.