Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start supporting arm32v7 armv7 starting with 3.9 #484

Closed
wants to merge 1 commit into from
Closed

Start supporting arm32v7 armv7 starting with 3.9 #484

wants to merge 1 commit into from

Conversation

oliv3r
Copy link

@oliv3r oliv3r commented Feb 4, 2019

With alpine 3.9 out the door, and it now officially supporting armv7 (http://dl-cdn.alpinelinux.org/alpine/v3.9/main/armv7/) also start creating docker builds for it.

@tianon
Copy link
Collaborator

tianon commented Feb 4, 2019 via email

@oliv3r oliv3r changed the title Start supporting arm32v7 armv7 Start supporting arm32v7 armv7 starting with 3.9 Feb 4, 2019
@oliv3r
Copy link
Author

oliv3r commented Feb 4, 2019

@tianon what did you mean with your comment? I know the docker images do not support it yet; but alpine now has armv7 builds out, so this should be the first step to generate them right?

@tianon
Copy link
Collaborator

tianon commented Feb 4, 2019

Doh sorry yeah, I misread which repo this was on 😅

In this case, the RHS of this case should be arm32v7 to match official images arch designations.

@oliv3r
Copy link
Author

oliv3r commented Feb 19, 2019

In this case, the RHS of this case should be arm32v7 to match official images arch designations.

Not sure what you mean here either :) What does RHS stand for? Is there anything that's expected here from me?

build Outdated Show resolved Hide resolved
@frenck
Copy link

frenck commented Mar 4, 2019

Superseded by #487 ?

@oliv3r
Copy link
Author

oliv3r commented Mar 5, 2019

Superseded by #487 ?

I would rather say #487 is a duplicate?

Anyway, I created the changes I thought where needed for armv7 images last week; and they have since been merged in alpinelinux/aports#6444.

So I think we now need to check how useable these images are, if there was anything omitted in the alpine armv7 PR and what was missing in this PR to get these images going?

@oliv3r
Copy link
Author

oliv3r commented Mar 5, 2019

I saw that there's no script that generates the armv7 subdirectory, even though it seems to be completely identical to a least the armhf variant.

What I am not clear on, is how the versioning works. Currently only alpine 3.9.1 and 3.9.2 minirootfs are built, but the option files list 3.9.0. I'll open a ticket on alpine to see if they can back-generate the 3.9.0 rootfs for completness.

@oliv3r
Copy link
Author

oliv3r commented Mar 5, 2019

Also, the 'supported architectures' on docker hub is probably done at a later point in the official repo, I suppose only maintainers can do that later, correct?

@frenck
Copy link

frenck commented Mar 5, 2019

I would rather say #487 is a duplicate?

Fine by me, at the time of writing, #487 was more complete, hence my comment.
Personally, I'm desperately looking forward to using armv7, whose PR is getting merged is not a concern to me.

With alpine 3.9 out the door, and it now officially supporting armv7
(http://dl-cdn.alpinelinux.org/alpine/v3.9/main/armv7/)
also start creating docker builds for it.

Signed-off-by: Olliver Schinagl <[email protected]>
@oliv3r
Copy link
Author

oliv3r commented Mar 5, 2019

So I can build local armv7 containers, so this PR is 'complete' but requires a version bump to 3.9.1 or 3.9.2 as there is no armv7 3.9.0 over on alpine. Not sure if the 3.9.0 bump for armv7 is heared there though (alpinelinux/aports#6444). So I'll probably hit @ncopa up on IRC.

Until then see #497 which I think should be merged first, to keep the general alpine version in sync.

@oliv3r
Copy link
Author

oliv3r commented Apr 2, 2019

We best close this pull-request as the organizational structure has changed, with alpine linux now hosting their own Dockerfiles. Docker hub now seems to have armv7 so we should be able to use those as well.

@oliv3r oliv3r closed this Apr 2, 2019
@oliv3r oliv3r deleted the patch-1 branch April 2, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants