Add getter and setter for each command line option #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
reviewed
Mar 14, 2023
There was a problem hiding this comment.
See glencoesoftware/bioformats2raw#190 (review) for a first pass on the review of this new API
|
399f418 has the input/output path changes mentioned in glencoesoftware/bioformats2raw#190, but I'm still working on a better way to set the compression type so that isn't ready for re-testing yet. |
The compression type now uses the new CompressionType enum, and compression options can be set with a CodecOptions object (that includes quality). The command line "--quality" will be wrapped in a CodecOptions behind the scenes, but this does not add any other command line arguments for setting compression options.
|
@sbesson: 0344585 was the last planned change I had here, so this is ready for review together with the current state of glencoesoftware/bioformats2raw#190. |
sbesson
approved these changes
Mar 29, 2023
| @Option( | ||
| names = "--max_workers", | ||
| description = "Maximum number of workers (default: ${DEFAULT-VALUE})" | ||
| ) | ||
| int maxWorkers = Runtime.getRuntime().availableProcessors(); | ||
| public void setMaxWorkers(int workers) { | ||
| maxWorkers = workers; |
There was a problem hiding this comment.
This could also use a minimal validation check that workers > 0 as in bioformats2raw
sbesson
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponds to glencoesoftware/bioformats2raw#190, see also glencoesoftware/NGFF-Converter#39.