Pyramid TIFF: ignore files where the first/last IFDs have different pixel types #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erindiel
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
Internal sample data with this issue have multiple series including slide label, overview, and scan image. Without this PR, there is only a single series written to the Zarr output.
With these changes, tests across two sample datasets produce the expected number of series in the Zarr output, each with correct dimensions and pyramid resolutions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to fix an edge case where there are multiple IFDs in descending size order that could be mistaken for a pyramid. The IFDs had a mix of uint8, uint8 RGB, and uint16 data.
Adding the
--extra-readersoption was a work-around in the meantime.