Remove the "--pixel-type" option #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this primarily referring to the min/max calculation per channel which is now happening by default in
Re-reading the original issue, I think we are talking about a data loss issue which is arguably one of the worst kind in a conversion library. I would also support dropping the option entirely. |
erindiel
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154.
As described in #154,
--pixel-typenever worked quite right, and we now have other ways to solve the problems it was meant to fix. This removes the option entirely (no deprecation), but could be changed to keep the option a no-op if anyone feels strongly.Maybe worth including in the next patch release along with #171 (review)?