Merge `php8` back into `master` #809

czosel · 2021-10-24T14:43:20Z

Updated version of #807 with resolved conflicts

…rator add php8 nullsafe operator

…n types

feat(php8): union types with new AST node

…tch-statement # Conflicts: # src/ast/matcharm.js

feat(php8): match expression

feat(php8): named arguments

…d-props Fixed parsing of optional promoted properties when type is nullable

PHP8 Attrributes repeating

… parsing classes and interfaces

…n-src-location Fix method flags in src location

…for-static-type-return Add support for static type return

ichiriac

That's the first quick review of the code, I would need to run it on my computer and read it again, complementary with coments made on #807

ichiriac · 2021-10-24T14:50:56Z

src/lexer/scripting.js

@@ -16,6 +16,11 @@ module.exports = {
      case "\r\n":
        return this.T_WHITESPACE();
      case "#":
+        if (this._input[this.offset] === "[") {


should check the php version before parsing as PHP8

src/parser/try.js

ichiriac · 2021-10-24T15:03:44Z

test/snapshot/attributes.test.js

+    ).toMatchSnapshot();
+  });
+  it("can parse anon-class attributes", () => {
+    expect(parser.parseEval(`$a = new #[T] class {};`)).toMatchSnapshot();


could be cool to add tests over previous PHP versions in order to test non regressions

added a test for anonymous classes and functions

ichiriac · 2021-10-24T15:04:50Z

test/snapshot/attributes.test.js

+        }
+    `)
+    ).toMatchSnapshot();
+  });


missing tests over bad syntax on php 8 like :

#[Foo] $a = 1;

Good call - turns out we're currently dropping the first line instead of parsing it as a comment. I'm not sure about how to fix this correctly, shall we create a separate issue for it? cc @cseufert

Yes, I guess we need to check if the attribute was consumed, and if not, throw an error. Sorry been absolutely flat out, but will have a look when I get some time.

@cseufert no worries, thanks for the feedback!

test/snapshot/call.test.js

ichiriac · 2021-10-24T15:07:49Z

test/snapshot/class.test.js

+  it("knows where a function definiton starts", function () {
+    const phpCode = `
+class b { 
+  // prettier-ignore


should also test with an attribute (as I think they are also included)

class... { #[Foo] // comment public function ... }

This case is already covered here: https://github.com/glayzzle/php-parser/pull/809/files#diff-afaacbd57a577ff9abf9ab4d44fc4ca9a4a814f5ed5fb7a6b381494d268bb5c0R32 (attributes.test.js, can parse params with comments)

czosel · 2021-10-24T19:55:36Z

@ichiriac @cseufert I'm not sure how much time I'll find to address the comments in the review in the coming days. If you find time, feel free to add commits to this PR (php8 branch on my fork, czosel/php8).

czosel · 2021-11-06T19:32:15Z

Hi @ichiriac 🙂 Do you think we can move forward with this? The only open issue is #809 (comment), which we can address in a separate PR i think.

czosel · 2021-12-04T16:16:18Z

@ichiriac friendly bump 🙃

czosel · 2021-12-29T20:53:54Z

Hi @ichiriac, happy holidays 🙂 Is there anything I can do to help move this forward?

jebarjonet · 2022-01-19T10:29:48Z

@czosel Thanks for this PR 🙂 Should you find someone else to review this PR since @ichiriac has not been answering for months ? This is a pretty big update and it will be useful to a couple of linting and formatting tools for PHP 8.

jaulz · 2022-01-19T10:33:06Z

Maybe @b4dnewz can help since he is the second member of glayzzle?

czosel · 2022-01-19T11:45:19Z

@jebarjonet Yeah, it would be great if someone else could take a look. I'm not sure if anyone else next to @ichiriac knows the codebase well enough, but I guess slowly the benefits of moving this forward outweigh the risk of introducing issues (which can then be fixed). I also have merge permissions on the repo, but I'd prefer not to use them without anyone else's approval 😉

alexander-akait · 2022-01-29T12:56:25Z

@ichiriac Friendly ping

Selion05 and others added 30 commits February 24, 2021 10:28

add php8 nullsafe operator

8b77c60

add tests

4ca49ba

Merge pull request glayzzle#662 from Selion05/issue-658-null-safe-ope…

7de81ca

…rator add php8 nullsafe operator

first pass at implementing match expression

6e62c9a

added support for multiple match lhd tokens

c0e1f5c

added match statement support and supporting tests

62e3880

simplified read_match_pair function

9e94c03

Added support for union types in function parameters & function retur…

968da4e

…n types

Addes support for union types as part of classes

5aed303

made a new node ast node for union types

7400599

dont set name for ast node

0c33bf5

Fix JSDoc references to class name

66a5cde

Update MatchEntry JSDoc

08cbfeb

Fix JSDoc

a358ccc

fix for types JSDoc

ddae3e3

Merge pull request glayzzle#693 from moddengine/php8-union-types-v2

82970fd

feat(php8): union types with new AST node

updated names to follow PHP-Parser

219cc2d

Merge remote-tracking branch 'modd/php8-match-statement' into php8-ma…

f34e910

…tch-statement # Conflicts: # src/ast/matcharm.js

feat(php8): named arguments

6b2a654

refactor: reset state instead of try / catch

39b527c

Added modifier flags to parameter ASK and read param visibility params

1c0bf27

removed defaultkeyword ast node

3c92a4d

improved test coverage

c65f7b2

remove unused prop for JSDoc

762181d

Updated JSDoc & added nested testcase

7bceb3f

added support for hanging comma

af9503a

remove check for leading comma

6e91308

support throw as expression in match statement

d27e051

Merge pull request glayzzle#686 from moddengine/php8-match-statement

da4f3f5

feat(php8): match expression

Merge pull request glayzzle#673 from czosel/named-arguments

0b7781f

feat(php8): named arguments

czosel and others added 8 commits August 16, 2021 08:57

Merge pull request glayzzle#785 from moddengine/php8-nullable-promote…

9c35df7

…d-props Fixed parsing of optional promoted properties when type is nullable

fix for attributes repeating

4f6f378

Merge pull request glayzzle#788 from moddengine/php8-attrs-repeating

4c5b067

PHP8 Attrributes repeating

Add support for static type return

7b861e9

Include visibility/abstract/final/static flags as part of source when…

af736bb

… parsing classes and interfaces

Merge pull request glayzzle#792 from moddengine/cs-fix-method-flags-i…

61f4d67

…n-src-location Fix method flags in src location

Merge pull request glayzzle#791 from fernando-rivas-smtp/add-support-…

27abcb2

…for-static-type-return Add support for static type return

Merge branch 'master' into php8

ad46364

czosel requested a review from ichiriac October 24, 2021 14:43

czosel mentioned this pull request Oct 24, 2021

Merge php8 back into master #807

Closed

ichiriac requested changes Oct 24, 2021

View reviewed changes

Merge branch 'master' into php8

a02039b

czosel added 5 commits October 24, 2021 22:23

fix linting

21ccf4a

fix: attribute parsing version check

840958e

fix: catch without variable version check

3b39831

chore: add tests for anonymous class/fn attributes in php < 8

b3089eb

chore: improve coverage / add explicit ignore statements

17b4788

jaulz mentioned this pull request Nov 2, 2021

Add PHP 8 Support / WIP #486

Open

1 task

czosel mentioned this pull request Jan 14, 2022

php-parser integrity error after plugin-php update prettier/plugin-php#1836

Closed

czosel mentioned this pull request Jan 28, 2022

PHP parser dependency makes the GitHub Actions fail prettier/plugin-php#1822

Closed

alexander-akait approved these changes Jan 29, 2022

View reviewed changes

czosel merged commit f6e545f into glayzzle:master Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge `php8` back into `master` #809

Merge `php8` back into `master` #809

czosel commented Oct 24, 2021

ichiriac left a comment

ichiriac Oct 24, 2021

czosel Oct 30, 2021

ichiriac Oct 24, 2021

czosel Oct 30, 2021

ichiriac Oct 24, 2021

czosel Oct 30, 2021 •

edited

Loading

cseufert Nov 7, 2021

czosel Nov 8, 2021

ichiriac Oct 24, 2021

czosel Oct 30, 2021 •

edited

Loading

czosel commented Oct 24, 2021

czosel commented Nov 6, 2021

czosel commented Dec 4, 2021

czosel commented Dec 29, 2021

jebarjonet commented Jan 19, 2022

jaulz commented Jan 19, 2022

czosel commented Jan 19, 2022

alexander-akait commented Jan 29, 2022

Merge php8 back into master #809

Merge php8 back into master #809

Conversation

czosel commented Oct 24, 2021

ichiriac left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

czosel Oct 30, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

czosel Oct 30, 2021 • edited Loading

Choose a reason for hiding this comment

czosel commented Oct 24, 2021

czosel commented Nov 6, 2021

czosel commented Dec 4, 2021

czosel commented Dec 29, 2021

jebarjonet commented Jan 19, 2022

jaulz commented Jan 19, 2022

czosel commented Jan 19, 2022

alexander-akait commented Jan 29, 2022

Merge `php8` back into `master` #809

Merge `php8` back into `master` #809

czosel Oct 30, 2021 •

edited

Loading

czosel Oct 30, 2021 •

edited

Loading