Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8 non-capturing exception #755

Merged
merged 2 commits into from
Jun 19, 2021
Merged

PHP8 non-capturing exception #755

merged 2 commits into from
Jun 19, 2021

Conversation

eldair
Copy link
Contributor

@eldair eldair commented Jun 18, 2021

Hello,

This is my first pull request for this project. I am trying to add functionality for non-capturing exceptions. Let me know if something else in the code needs updating, I'm not that familiar with entire codebase :/

@eldair eldair mentioned this pull request Jun 18, 2021
1 task
Copy link
Collaborator

@cseufert cseufert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@cseufert
Copy link
Collaborator

@czosel can you take a look when you have a minute

Copy link
Collaborator

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me as well, thanks for contributing @eldair !

@czosel czosel merged commit 425c4dc into glayzzle:php8 Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants