Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: race-condition problem on testhelper (#5) #8

Conversation

karupanerura
Copy link
Contributor

switch to context based log writer override

@glassonion1
Copy link
Owner

Thanks for the pull request. I have a question.

It seemed that the SetContextConfig function was only used in the test.
Are you aware that ContextConfig will only be used for testing?

Please tell me what kind of problem occurred in the test.

If it's a test-specific issue, I think it's better to fix it so that it doesn't affect the production code.

@glassonion1 glassonion1 reopened this Feb 28, 2023
@glassonion1 glassonion1 merged commit f037fda into glassonion1:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants