Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we drop 3.8-3.9 support? #198

Closed
paddyroddy opened this issue Sep 11, 2024 · 4 comments · Fixed by #326
Closed

Should we drop 3.8-3.9 support? #198

paddyroddy opened this issue Sep 11, 2024 · 4 comments · Fixed by #326
Assignees
@paddyroddy
Labels
maintenance Maintenance: refactoring, typos, etc. question Further information is requested

Comments

@paddyroddy
Copy link
Member

According to SPEC0 it currently recommends dropping everything below 3.10, NEP29 agrees similarly. Can read more about the motivation here. Any good reason to support 3.8-3.9?
@paddyroddy paddyroddy added the question Further information is requested label Sep 11, 2024
@paddyroddy paddyroddy added the maintenance Maintenance: refactoring, typos, etc. label Sep 11, 2024
@Saransh-cpp
Copy link
Member

Dropping 3.8 might make sense as array-api-compat only supports Python 3.9+. 3.9 should only be dropped if it is blocking a major functionality in the codebase, which I don't think it is.

@paddyroddy
Copy link
Member Author

should only be dropped

I feel this is personal choice, many in the scientific community are leaning towards more aggressive dropping old Python support. We had this discussion in our Python Tooling recently UCL-ARC/python-tooling#362.

@paddyroddy
Copy link
Member Author

Looks like we have to drop 3.8 for NumPy v2 migration https://github.com/glass-dev/glass/actions/runs/10833030831/job/30058811483?pr=207

@paddyroddy
Copy link
Member Author

Think we have to drop 3.9 too https://github.com/numpy/numpy/releases/tag/v2.1.1

@paddyroddy paddyroddy mentioned this issue Sep 12, 2024
Closed
@paddyroddy paddyroddy linked a pull request Sep 12, 2024 that will close this issue
gh-163: full support of NumPy v2 #207
Closed
@paddyroddy paddyroddy assigned paddyroddy and unassigned ntessore Sep 12, 2024
This was referenced Oct 4, 2024
Merged
Closed
paddyroddy added a commit that referenced this issue Oct 4, 2024
@paddyroddy
gh-198: enforce python>3.8 & numpy>1.21 (#326)
3af516f 
Closes #198. For Array API support (#67), we need minimum versions of:

1. `Python 3.9` as specified here
https://data-apis.org/array-api-compat/changelog.html#id9
2. `NumPy 1.22` as specified here
https://numpy.org/doc/stable/reference/array_api.html#array-api-standard-compatibility

In this PR I have enforced both of these. The code changes have come
from `ruff` linting, utilising the benefits from
[3.9](https://docs.python.org/3/whatsnew/3.9.html).

I also removed some of the overzealous comments on imports. They weren't
adding anything and meant the imports took up more room.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paddyroddy paddyroddy

Labels
maintenance Maintenance: refactoring, typos, etc. question Further information is requested
Projects
None yet
Milestone
No milestone
3 participants
@ntessore @paddyroddy @Saransh-cpp