Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superfan outfit and disguise are not using 47's head, instead they are using a civilian model #225

Open
dribbleondo opened this issue Nov 8, 2024 · 4 comments

Comments

@dribbleondo
Copy link
Contributor

dribbleondo commented Nov 8, 2024

47's head is not underneath the mask. While this is a very minor problem, it strikes me as inconsistent that IO would do this (In fact, i'm fairly certain they did this in a hurry back in 2016-17) and not alter the mask afterward to fit both outfit and disguise heads.

image

Thanks to Zach on discord for the above image.

The tell is that there's a noticeable difference in the neck's skin colour if you look in the inventory.

I fixed this by modifying 47's S3 weightedprim head usually associated with such suits, removed his facial area (including his lips, not pictured):

image

And we get this!:

image

An overly-complicated solution to fix a very minor problem. Perfect for this mod.

This was made for the projects board, a pull with this fix will be added if the chore pull goes through.

@Ocean-Minnow
Copy link
Contributor

I feel like it would be better to override the skin tone to match 47's usual one rather than including an entire new PRIM with the mod for something so small. Doing this once wouldn't add a significant amount of file size or deploy time, but I don't want to make a habit out of it, since it would start adding up eventually.

@dribbleondo
Copy link
Contributor Author

dribbleondo commented Nov 8, 2024

I feel like it would be better to override the skin tone to match 47's usual one rather than including an entire new PRIM with the mod for something so small. Doing this once wouldn't add a significant amount of file size or deploy time, but I don't want to make a habit out of it, since it would start adding up eventually.

Making a new texture to override the skintone would be significantly worse for filesize (For some context, 2K textures are ~2-4MB each), this fix in total is almost 1/15th the size, doing vague napkin maths in my head.

Even if we alter the texture via variables in the entity (which, in itself, is very tedious and I'd rather not do that), that may not be 100% accurate. I don't think adding altered custom PRIMs, or custom PRIM heads, will start any kind of habit tbh.

I dunno, I just find it very weird that some random guy is behind the mask and IO have never really changed it, when no other suit does this (to my knowledge at least).

EDIT: Looking into material swapping right now.

@RDIL
Copy link
Member

RDIL commented Nov 8, 2024

In what scenario would the user see this?

@Ocean-Minnow
Copy link
Contributor

AFAIK they'd never see the head itself - it's the neck being colored differently that's the issue. We've discussed this on Discord in more depth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
3 participants