Use Array.from instead of [].slice

[KSXGitHub]

Example code

function * gen ()
  yield 123
  yield 456
  yield 789

console.log [...gen()]

Expected JavaScript

function* gen(){
  (yield 123);
  (yield 456);
  return (yield 789);
}
console.log(Array.from(gen())); // This would print [123, 456, 789]

Current JavaScript

var slice$ = [].slice;
function* gen(){
  (yield 123);
  (yield 456);
  return (yield 789);
}
console.log(slice$.call(gen())); // This would print an empty array

[dk00]

Array.from requires ES6 support, and if a JS engine knows Array.from, it should also know spread(...expression)

If we decide to output ES6, we can use spread here, spread can be used with any iterables(including generators) like Array.from.

splat-in-array = [a, ...b, c, ...gen!]
splat-in-object = {a, ...b, c, ...d}
call-with-splat-parameters = fn a, ...b, c, ...d

var splatInArray, splatInObject, callWithSplatParameters
splatInArray = [a, ...b, c, ...gen()];
splatInObject = {
  a,
  ...b,
  c,
  ...d
};
callWithSplatParameters = fn(a, ...b, c, ...d);

[rhendric]

Targeting ES6 has been discussed elsewhere, I believe, and if it's worth doing, it's worth doing in the context of a broader review of the backend, such as #862. In the meantime, this can certainly be addressed in an ES3-compatible way, which is my intent.

[KSXGitHub]

@dk00 We can use polyfill

[vendethiel]

@rhendric congrats on the badge!

[determin1st]

thanks 8)