Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix <p> and <div> order for block 'scenario-container' #97

Merged
merged 2 commits into from
Jul 17, 2017

Conversation

hkhc
Copy link
Contributor

@hkhc hkhc commented Jul 13, 2017

  • The <p> and <div> elements are not nested properly.
  • The "step name" shall be escaped to make a well-formed HTML output.

@gkushang
Copy link
Owner

Thanks for the PR! Looks good 👍

@@ -77,7 +77,7 @@
<% } %>
<span class="text">
<span class="keyword highlight"><%= step.keyword %></span>
<span> <%= step.name %></span>
<span> <%- step.name %></span>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gkushang gkushang merged commit f1563ba into gkushang:develop Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants