Support scoped packages #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joscha thanks for the fix. |
gkushang
reviewed
Jul 10, 2017
| @@ -16,6 +16,7 @@ var generateReport = function (options) { | |||
| var packageJson = {}; | |||
| try { | |||
| packageJson = packageJsonPath && jsonFile.readFileSync(packageJsonPath, 'utf8'); | |||
| packageJson.name = packageJson.name.replace('@','__').replace('/','_'); // sanitize scoped packages | |||
There was a problem hiding this comment.
We are sanitizing the string at more than one places; will generalize it & sanitize the suite.name since it's been passed to the HTML templates.
|
@gkushang is there anything else I can do? Also, would be awesome if you could ping on this ticket when a version with the fix has been released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92