Implemented feature hierarchy template #76
Conversation
Make leaf features show up first before sub-suites in hierarchy report Fix logic in hierarchy report to deal with subsuites that I broke when I generalized it to deal with features having no sub-structure. oops.
| @@ -82,26 +91,53 @@ var generateReport = function (options) { | |||
| sec > 0 ? formattedTimeStamp += sec + SECONDS : ''; | |||
| ms > 0 ? formattedTimeStamp += ms + MILLI_SECONDS : ''; | |||
|
|
|||
| return formattedTimeStamp.trim().length === 0 ? '0s' : formattedTimeStamp; | |||
| return formattedTimeStamp.trim().length === 0 ? '<1ms' : formattedTimeStamp; | |||
lib/reporter.js
Outdated
| return suite; | ||
|
|
||
| }); | ||
|
|
||
| suite.totalTime = calculateDuration(suite.totalTime); | ||
|
|
||
| suite.features = featureOutput; | ||
| setupSubSuiteTemplates(suite); |
There was a problem hiding this comment.
Its breaking the existing functionality with other formatted reports when there is a hierarchy of feature files, with the templates bootstrap , foundation or simple.
To try - please move the happy.feaure and unhappy.features to respective directories, e.g. features/happy/happy.feature` and pls checkout the other templates HTML reports.
To run the tests npm run features
templates/hierarchy/piechart.js
Outdated
| @@ -0,0 +1,45 @@ | |||
| function drawChart(chartData) { | |||
There was a problem hiding this comment.
To keep it DRY, Could we use the existing piechart.js from bootstrap directory?
templates/hierarchy/script.js
Outdated
| @@ -0,0 +1,24 @@ | |||
| $(document).ready(function() { | |||
There was a problem hiding this comment.
To keep it DRY, Could we use the existing script.js from bootstrap directory?
since it is possible we have have a folder hierarchy but are using one of the "flat" reports. Remove duplicate script.js and piechart.js files from hierarchy, instead refer to the sources from bootstrap.
|
Nice work @cstrong ! It looks good overall. I've a suggestion in terms of view and displaying the report as a dashboard. Let me know what you think. I do have local changes that can be reviewed as a future improvements/PR. Suggestion: Instead of wrapping all directories under Reasons: One less click & can easily viewable on dashboard as overall results. Some of the users display the HTML report on a Dashboard (TV) which refreshes every few minutes. Having all features on single page would give them a nice overview.
|
|
hmmm you make a convincing case! I agree the information along the top already gives you a summary, so the top "All Features" is a bit redundant. OK I am good with it! Let me know if you want to push your changes to this branch and merge it, or want to do it in a separate PR, or you want me to make the change. I do have a concern about alignment, however. When I made the panels aligned with the pie charts, the scenarios got squished. Because we are adding potentially multiple levels of nesting we need more space, don't you think? |
|
I agree. I am afraid of nesting as well, but I believe it really depends on the users. The best results can be achieved for max 2 level of nesting, and I've hardly seen the nested directories beyond 2 levels. We must have to set some exceptions in README while using this template. However, the scenarios panels are responsive and we would need minor alignment with the
|
|
works for me. The template only supports up to 3 levels of nesting anyway. I think that should be enough even for very large projects. |
New "hierarchy" report template (see #75 )
Fixed a few linter errors
Added some code comments
Made a few gratuitous changes in calculateDuration that made the code easier for me to understand, feel free to disagree