Bootstrap template fixes #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for reports with a big number of screenshots
…ot is expanded when we click on "Screenshot +" link. In previous variant more then one screnshot could be expanded by one click
|
Not sure why travis-ci fails. All tests are passed on my local machine |
|
Thanks, @anrodkin for the PR. Let me take a look why it fails |
|
Done |
gkushang
reviewed
Mar 23, 2017
templates/bootstrap/features.tmpl
Outdated
| @@ -134,9 +134,9 @@ this.Then(/^<%= step.name.replace(/"[^"]*"/g, '"\(\[\^\"\]\*\)"') %>$/, function | |||
| <% } %> | |||
|
|
|||
| <% if (step.image) { %> | |||
| <a class="toggle" href="#">Screenshot -</a> | |||
| <a class="toggle" href="javascript: void(0);">Screenshot -</a> | |||
There was a problem hiding this comment.
Could you change the toggle from - to + at Screenshot - so that Screenshot would launch at the first click? Otherwise, the user has to click twice initially.
|
All set. Published with v0.3.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for BOOTSTRAP template