Upgraded for compatibility with Cucumber v8.9.1 + dependencies updated #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srbarrios
reviewed
Nov 4, 2024
Comment on lines
+6
to
+11
| .DS_Store | ||
| /samples/.DS_Store | ||
| templates/.DS_Store | ||
| templates/_common/.DS_Store | ||
| test/.DS_Store | ||
| test/features/.DS_Store |
There was a problem hiding this comment.
All those should be on your global git configuration, not in the repository.
It does not make sense to start ignoring leftovers made by each operating system or IDE.
srbarrios
reviewed
Nov 4, 2024
|
|
||
| function trackScenarioRetries(scenarios) { |
There was a problem hiding this comment.
It would be good to list this as a feature in the description of the PR, plus in the changelog.
srbarrios
reviewed
Nov 4, 2024
Comment on lines
-45
to
-61
| function selectHandler() { | ||
| var selectedItem = chart.getSelection()[0]; | ||
| if (selectedItem) { | ||
| var featureStatus = data.getValue(selectedItem.row, 0); | ||
| if (featureStatus === 'Passed'){ | ||
| var x = $('.feature-passed'); | ||
| }else{ | ||
| var x = $('.feature-failed'); | ||
| } | ||
| if (x && x.css('display') === "none") { | ||
| x.css('display', 'block'); | ||
| } else { | ||
| x.css('display', 'none'); | ||
| } | ||
| } | ||
| } | ||
| google.visualization.events.addListener(chart, 'select', selectHandler); |
There was a problem hiding this comment.
@carlosbermejop would you mind to have this feature back?
It was really helpful for my team.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!,
This is the upgrade to the project to make it compatible with Cucumber v8.9.1. The remaining dependencies were also updated except for
chalk, as it's only compatible with type module projects.Cheers!