Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for issue #163, generate report for cucumber_report_{random_num}.json #210

Conversation

hujunhaorobert
Copy link
Contributor

@hujunhaorobert hujunhaorobert commented Dec 3, 2019

When I come to use cucumber-html-report npm package, I got similar errors as the descriptions in the issues #163, #206
My cucumber related config was as below:
"dependencies": {
"@types/cucumber": "^6.0.0",
...
"cucumber": "^6.0.5",
"cucumber-html-reporter": "^5.0.2",
}.
After some debugging into the npm package, I noticed that a file with name cucumber_report_{random_num}.json was dynamically created instead of hardcoded file name cucumber_report.json
The proposed commit solution fixed the problems. I hope this fix solution can be integrated into cucumber-html-report official release and also benefit others.

@hujunhaorobert
Copy link
Contributor Author

@gkushang, the pull request is to fix the issue #163, #206. I have tested in this change in Github Travis CI and also my working project. The Cucumnber html report can be successfully generated. Please review this change. Hopefully the fix solution can be released into a new version ASAP.

Copy link
Owner

@gkushang gkushang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hujunhaorobert

👍 thank you for contributing!

@gkushang gkushang merged commit 9825dd2 into gkushang:develop Dec 15, 2019
@gkushang
Copy link
Owner

published with [email protected] 🚀

@hujunhaorobert hujunhaorobert deleted the bugfix/issue-#163-generate-cucumber-report-for-cucumber_report_{radome-number}_json branch December 15, 2019 23:46
@deepank2596
Copy link

deepank2596 commented May 31, 2020

using jsonDir in place of jsonFile in onComplete>>options also helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants