fix(android): ensure rate is never set to 0 (TheWidlarzGroup#3593)

* fix(android): ensure rate is never set to 0 --------- Co-authored-by: Olivier Bouillet <[email protected]>
gkueny · Mar 21, 2024 · 3d7444a · 3d7444a
1 parent 408cfb2
commit 3d7444a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java b/android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
@@ -1903,6 +1903,11 @@ public void seekTo(long positionMs) {
     }
 
     public void setRateModifier(float newRate) {
+        if (newRate <= 0) {
+            DebugLog.w(TAG, "cannot set rate <= 0");
+            return;
+        }
+
         rate = newRate;
 
         if (player != null) {

diff --git a/docs/pages/component/props.mdx b/docs/pages/component/props.mdx
@@ -434,8 +434,8 @@ Default: 250.0
 
 Speed at which the media should play.
 
-- **0.0** - Pauses the video
-- **1.0** - Play at normal speed
+- **0.0** - Pauses the video (iOS only)
+- **1.0** - Play at normal speed (default)
 - **Other values** - Slow down or speed up playback
 
 ### `repeat`

diff --git a/examples/basic/src/VideoPlayer.tsx b/examples/basic/src/VideoPlayer.tsx
@@ -638,11 +638,13 @@ class VideoPlayer extends Component {
                 />
               </View>
               <View style={styles.generalControls}>
+                {/* shall be replaced by slider */}
                 <MultiValueControl
-                  values={[0.25, 0.5, 1.0, 1.5, 2.0]}
+                  values={[0, 0.25, 0.5, 1.0, 1.5, 2.0]}
                   onPress={this.onRateSelected}
                   selected={this.state.rate}
                 />
+                {/* shall be replaced by slider */}
                 <MultiValueControl
                   values={[0.5, 1, 1.5]}
                   onPress={this.onVolumeSelected}