Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change invoke rtrim to false as default #49

Closed
danutavadanei opened this issue Mar 8, 2018 · 2 comments
Closed

Change invoke rtrim to false as default #49

danutavadanei opened this issue Mar 8, 2018 · 2 comments

Comments

@danutavadanei
Copy link

I think we should change rtrim option to false by default. It breaks compatibility with older versions and I think it will affect many users. It already affects all my applications.
@gkralik
Copy link
Owner

gkralik commented Mar 8, 2018

Yes, you are right. I will push an updated version soon.

gkralik added a commit that referenced this issue Mar 8, 2018
@gkralik
disable rtrim option by default
4bcc3ed 
this fixes a BC break introduced in bfe868c.

refs #49
gkralik added a commit that referenced this issue Mar 8, 2018
@gkralik
release version 1.2.1
6e85099 
refs #49
@gkralik
Copy link
Owner

gkralik commented Mar 8, 2018

Version 1.2.1 makes the rtrim option default to false.
Documentation has been updated to reflect this change.

@gkralik gkralik closed this as completed Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gkralik @danutavadanei