Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Correctly deserialize ISO 8601 string with timezone offset #44

Merged
merged 1 commit into from
Feb 3, 2019
Merged

[BUGFIX] Correctly deserialize ISO 8601 string with timezone offset #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/fatboyindustrial/gsonjodatime/DateTimeConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public DateTime deserialize(JsonElement json, Type typeOfT, JsonDeserializationC
return null;
}

final DateTimeFormatter fmt = ISODateTimeFormat.dateTimeParser();
final DateTimeFormatter fmt = ISODateTimeFormat.dateTimeParser().withOffsetParsed();
return fmt.parseDateTime(json.getAsString());
}
}
13 changes: 13 additions & 0 deletions src/test/java/com/fatboyindustrial/gsonjodatime/DateTimeConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,4 +101,17 @@ public void testDeserializeWithoutMilliseconds()

assertThat(gson.fromJson(str, DateTime.class), is(expected));
}

/**
* Tests that deserialising an ISO 8601 string with a timezone offset works
*/
@Test
public void testDeserializeWithTimezoneOffset()
{
final Gson gson = Converters.registerDateTime(new GsonBuilder()).create();
final String str = "2019-01-31T10:37:20.631+01:00";
final String json = "\"" + str + "\"";

assertThat(gson.fromJson(json, DateTime.class).toString(), is(str));
}
}