Feature addition, add noise to mimic #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkhayes
requested changes
Nov 3, 2019
| @@ -456,7 +456,7 @@ def genetic_alg(problem, pop_size=200, mutation_prob=0.1, max_attempts=10, | |||
|
|
|||
|
|
|||
| def mimic(problem, pop_size=200, keep_pct=0.2, max_attempts=10, | |||
| max_iters=np.inf, curve=False, random_state=None, fast_mimic=False): | |||
| max_iters=np.inf, curve=False, random_state=None, fast_mimic=False,noise=0): | |||
There was a problem hiding this comment.
Could you please update the parameters list to include a description of the noise parameter.
| @@ -272,6 +272,7 @@ def __init__(self, length, fitness_fn, maximize=True, max_val=2): | |||
| self.sample_order = [] | |||
| self.prob_type = 'discrete' | |||
| self.mimic_speed = False | |||
| self.noise=0 | |||
There was a problem hiding this comment.
I can't see where self.noise gets updated to the noise value set in the mimic function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature lets users add noise to mimic.
Users can add an optional "noise" argument to set the noise between 0.00 ~ 0.10, which corresponds to 0 to 10% noise. (Which gets renormalized). The default is set to 0.
0.01 corresponds to adding 1% probability to all probabilities and conditional probabilities to the features and then renormalizing them.
Adopted from 4.3 Refining Samples Generated by MIMIC in Randomized Local Search as Successive Estimation of Probability Densities by Charles L. Isbell, Jr.