442 theme_essential: added custom slide size proof-of-concept

[kordan]

Sure you are right.
I added tags to .less too.
Now I have a couple more questions in addition to the ones I posted yesterday: is the "~" needed before tags in .less?
Do I need to add .less to config $THEME->sheets[]?

I hope you will decide to review my proof of concept and include it into the theme.
Thanks for your great work.
Daniele

[gjb2048]

Hi Daniele,

After sleeping on it, I'm intrigued by your solution and will review this update when I get a moment!

Ok, the tilda is needed before certain things in LESS so that it does not strip out what it does not understand as some stuff needs to be passed through to the CSS,

No you don't need to add '.less to config $THEME->sheets[]' as the LESS files are the source and the CSS is the output. Bog standard compiling methodology. Look at how C, C++, Java, Pascal.... etc. are orchestrated.

Cheers,

Gareth

[gjb2048]

I've updated master, update your version locally, switch to the master_442 branch and then do a rebase in that.

[gjb2048]

Hi Kordon,

Because the merge is failing and I want to test this out before putting in the main branch, I've created https://github.com/gjb2048/moodle-theme_essential/tree/master_442 and merged your commit into it. Then it will be easy to rebase / make changes in that development branch before combining into one commit for 'master' - you're contribution is credited in the log - if it goes, then I'll make really sure that you are recognised in the readme.

Cheers,

Gareth

[gjb2048]

Ok, as you can see from: db38ebd and the rest on: https://github.com/gjb2048/moodle-theme_essential/tree/master_442 - lots of changes to make things work. But still needs testing for each of the five width settings with the three layout settings. Run out of time now.

[kordan]

Thanks for your excellent work!

[gjb2048]

Its way from finished yet!

[gjb2048]

I will NOT merge this until its finished and fully tested. Any bugs I maintain so it MUST have none.

[kordan]

Ciao Gareth
I am still using my patch and it still works fine.
Are there difficulties to include it into official code?
You wrote it has to be "finished and fully tested". Isn't it?

[gjb2048]

Time, understanding that it will not cause me let more work, consideration of future maintenance work, thoughts about over complicating the theme even more... Perhaps it should be offered within a child theme.

Sent from my iPod in deep space...

On 18 Jun 2015, at 08:49, kordan [email protected] wrote:

Ciao Gareth
I am still using my patch and it still works fine.
Are there difficulties to include it into official code?
You wrote it has to be "finished and fully tested". Isn't it?

—
Reply to this email directly or view it on GitHub.

[gjb2048]

P.s. the last time I integrated something too soon it had bugs and took days to fix. Need concrete evidence of tests and test results.

Sent from my iPod in deep space...

On 18 Jun 2015, at 08:49, kordan [email protected] wrote:

Ciao Gareth
I am still using my patch and it still works fine.
Are there difficulties to include it into official code?
You wrote it has to be "finished and fully tested". Isn't it?

—
Reply to this email directly or view it on GitHub.

[kordan]

It is a pity because not always the huge carousel is welcome!!

[gjb2048]

Please don't bully me into this. It needs to be carefully thought out. I have only your word that its needed. Need lots of people stating that the want it etc.

Sent from my iPod in deep space...

On 18 Jun 2015, at 09:23, kordan [email protected] wrote:

It is a pity because not always the huge carousel is welcome!!

—
Reply to this email directly or view it on GitHub.

[gjb2048]

P.s. why oh why do requests come in for things to be done the day after a release?

Sent from my iPod in deep space...

On 18 Jun 2015, at 09:23, kordan [email protected] wrote:

It is a pity because not always the huge carousel is welcome!!

—
Reply to this email directly or view it on GitHub.

[kordan]

no, no!
The date of the release is 100% a coincidence. I asked for the integration in February!

[gjb2048]

Has it been that long? Sorry but paid work and bug fixes have to come first. This will take me hours to review and check.

Sent from my iPod in deep space...

On 18 Jun 2015, at 09:43, kordan [email protected] wrote:

no, no!
The date of the release is 100% a coincidence. I asked for the integration in February!

—
Reply to this email directly or view it on GitHub.

[gjb2048]

This is nothing in Moodle terms, look at: https://tracker.moodle.org/browse/MDL-372

Ok, look, I'm not against this, I appreciate what you have done. But Essential takes up 'soo' much time. Time I don't really have. At the moment I'm just trying to manage and fix bugs to get it to a more 'stable' situation. I'm having to draw the line and state that ALL enhancements must be funded in some way. If you look at the stats on https://moodle.org/plugins/stats.php?plugin=theme_essential and compare it with the list of donators in the Reame.md file then you'll see such a disparity. Everybody wants the theme but only the few want to support it.

Paid work 'has and must' come first, without it then 'nothing' happens. I've had a few bad experiences with code in Essential and need to be 100% sure that anything new is not going to cause me any grief.

If there is a credible list of people on the forum who put their money where their mouth is and say that they really 'really' want this, then I'll think again about finding time. Perhaps put a demo together and screen shots.