Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat binary class in tree_ensemble_classifier operator #510

Merged
merged 13 commits into from
Jan 6, 2024

Conversation

HappyTomatoo
Copy link
Contributor

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: 506

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@raphaelDkhn raphaelDkhn changed the base branch from main to develop December 18, 2023 07:59
Copy link
Collaborator

@raphaelDkhn raphaelDkhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HappyTomatoo Can you write tests for this please?

@HappyTomatoo
Copy link
Contributor Author

@raphaelDkhn Yes, I'll add that later

@HappyTomatoo
Copy link
Contributor Author

@raphaelDkhn Binary class test cases have been added.

Copy link
Collaborator

@raphaelDkhn raphaelDkhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raphaelDkhn raphaelDkhn merged commit 538eaa0 into gizatechxyz:develop Jan 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants