Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update to Cairo & Scarb v2.4.0 #494

Merged
merged 4 commits into from
Dec 10, 2023
Merged

chore: Update to Cairo & Scarb v2.4.0 #494

merged 4 commits into from
Dec 10, 2023

Conversation

akhercha
Copy link
Contributor

@akhercha akhercha commented Dec 9, 2023 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe): Bump cairo

What is the current behavior?

Issue Number: #493

What is the new behavior?

  • Updated codebase to Cairo v2.4.0

Does this introduce a breaking change?

  • Yes
  • No

Other information

TODO: Update cubic in Scarb.toml to https://github.com/influenceth/cubit after my PR there is merged:
influenceth/cubit#27

@akhercha akhercha changed the base branch from main to develop December 9, 2023 18:32
@akhercha akhercha marked this pull request as ready for review December 9, 2023 20:24
raphaelDkhn
raphaelDkhn approved these changes Dec 10, 2023
View reviewed changes
Copy link
Collaborator

@raphaelDkhn raphaelDkhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@raphaelDkhn raphaelDkhn merged commit c324e9d into gizatechxyz:develop Dec 10, 2023
1 check passed
@raphaelDkhn
Copy link
Collaborator

@all-contributors add @akhercha for code

@allcontributors allcontributors bot mentioned this pull request Dec 10, 2023
Merged
@allcontributors AllContributors
Copy link
Contributor

@raphaelDkhn

I've put up a pull request to add @akhercha! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaelDkhn raphaelDkhn raphaelDkhn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akhercha @raphaelDkhn