Feat: erf operator
#491
Merged
Feat: erf operator
#491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add erf testcase
docs: add erf
Modify it from a dictionary to conditional statement
raphaelDkhn
approved these changes
Dec 10, 2023
| } | ||
| } | ||
|
|
||
| fn get_lookup_table_values(key: felt252) -> u32{ |
There was a problem hiding this comment.
Instead of using dictionary here, that has a worse-case O(n) complexity for writing and reading. I would prefer implementing a Conditional Statements function, like here. Wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #349
What is the new behavior?
Does this introduce a breaking change?
Other information