complex numbers #481
Merged
complex numbers #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelDkhn
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
LGTM! Incredible work @chachaleo! The precision is good enough imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
Issue Number: #464
What is the new behavior?
I implemented the complex numbers, in a similarly to fixed point and signed integer.
I only implemented for FP64x64 for now but I can implement the ComplexTrait for other precision.
As a lot of functions implemented in the ComplexTrait use some not completely precise functions (Fixed point computations : sqrt, cos, ln,...) they don't return the exact results. I added comments in each tests with the expected result and the actual result so that you can have an idea of the precision and judge if the precision is good enough. If it's not good enough I'd love to investigate what we could do about it.
Also I can add additional complex analysis functions if needed.
I plan on also implement the corresponding Tensor but I wanted a feedback on this first to be sure I am in the right direction :)