fix encoding problems on windows with not using default encoding but … #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode branch names with calling repo.branch
|
Thanks a lot for your efforts! |
|
As part of spring cleaning, I am closing this PR as it was opened more than half a year ago while still being open due to unresolved or remarks. If this is a mistake or any other action should rather be taken, please let me know in the comments or create a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves encoding problem on windows with using fetch, pull, push commands. It similar to issues: 332, 237, explanation of problem I found here in accepted answer. Also was encoding problem with calling repo.branches, quite simillar, file open in default locale encoding (cp-1251) for me, and getting branches names was broken.